Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SearchPopup): displaying community channel's emojis #7761

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

alexandraB99
Copy link
Contributor

Closes #7702

What does the PR do

Fixes displaying comm channel's emojis in search location menu

Affected areas

Search location menu

Screenshot of functionality (including design for comparison)

emoj.mov

@status-im-auto
Copy link
Member

status-im-auto commented Oct 5, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e31b863 #1 2022-10-05 11:35:09 ~4 min linux-cpp 📦pkg
✔️ e31b863 #1 2022-10-05 11:39:52 ~9 min macos 📦dmg
✔️ e31b863 #1 2022-10-05 11:42:10 ~11 min linux 📦tgz
e31b863 #1 2022-10-05 11:47:09 ~16 min e2e 📄log
✔️ e31b863 #1 2022-10-05 11:52:20 ~21 min windows 📦exe
✔️ c910a85 #2 2022-10-06 12:11:08 ~5 min linux-cpp 📦pkg
✔️ c910a85 #2 2022-10-06 12:15:36 ~9 min macos 📦dmg
✔️ c910a85 #2 2022-10-06 12:17:41 ~11 min linux 📦tgz
✔️ c910a85 #2 2022-10-06 12:29:37 ~23 min windows 📦exe
⁉️ c910a85 #2 2022-10-06 12:37:36 ~15 min e2e 📄log

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions though

Copy link
Contributor

@glitchminer glitchminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original issue with search emojis appears resolved but on restoring account no prior chats/communities were restored. Assuming that these are related to network issues rather than icon fix.

General channel is also loading with black circles.
image

Copy link
Member

@micieslak micieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@alexandraB99 alexandraB99 merged commit 2ec0b53 into master Oct 6, 2022
@alexandraB99 alexandraB99 deleted the fix/issue-7702 branch October 6, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search filter community channels are missing icons
5 participants